I’ve been looking at this myself, although I don’t have any mp3s with accented characters in their metadata and have had to rely on scripts that Yvan’s sent me which contain substitution handlers to correct the results he gets.
The only point I’d add to this is that in the example I saw that had a “A\U0303\U…” sequence (for a ç, but otherwise similar), the ASObjC code returned it as Ã…, and iTunes also displayed it that way. Given that iTunes is reading from the .mp3 file’s metadata, and not the Spotlight metadata, that makes me think that that part of the problem is unrelated to the code at hand, and may well have been encoded into the file incorrectly in the first instance. In other words, what I think is happening in the mdls process is that à is being decomposed to A\U0303, and the following character is then escaped to \U00a9 or whatever.
For the below I was wanting that if either theGenre,theArtist,theTempo or theKey contain a null, then to prompt saying which file it is and then NOT move the file and continue with the next file.
#SOME MP3 TAGS ARE NOT PROPERLY FILLED OUT- THIS BELOW PART DOESNT WORK AS SCRIPT PROCEEDS??????. # problem solved below
if (count theGenre) ≤ (count "(null)") and theGenre contains "null" then set theGenre to "(no Genre)" # ADDED
if (count theArtist) ≤ (count "(null)") and theArtist contains "null" then set theArtist to "(no Artist)" # ADDED
if (count theTempo) ≤ (count "(null)") and theTempo contains "null" then set theTempo to "(no Tempo)" # ADDED
if (count theKey) ≤ (count "(null)") and theKey contains "null" then set theKey to "(no Key)" # ADDED
So it’s effectively a non-problem. I suspect the OP doesn’t have many French MP3s anyway, correctly coded or otherwise.
Since there’s been no feedback about that, and since the OP appears to have ignored the two scripts I posted, I don’t think there’s much else I can contribute to this thread. I’ve replaced the mainBusiness() handler in the ASObjC script with the working version of Shane’s and I’ve updated the “vanilla” script to handle null results in the same way.
But the version for use with mdls is slightly longer:
use AppleScript version "2.4" # requires at least Yosemite
use scripting additions
use framework "Foundation"
# Decode the string extracted by mdls from the metadata.
my decodeText("Le garA\\U0303\\U00a7on est arrivA\\U0303\\U00a9.")
my decodeText("Le gar\\U00e7on est arrive\\U0301.")
on decodeText(theText)
set |⌘| to current application
set theText to |⌘|'s class "NSString"'s stringWithString:(theText)
-- Set up and use a regex to find Unicode substitute expressions of the garbled kind (misderived from UTF-8 sequences).
set aHandyRegex to |⌘|'s class "NSRegularExpression"'s regularExpressionWithPattern:("([[:alpha:]]\\\\U[[:hex:]]{4})(\\\\U[[:hex:]]{4})") options:(0) |error|:(missing value)
set regexMatches to aHandyRegex's matchesInString:(theText) options:(0) range:({0, theText's |length|()})
set matchCount to (count regexMatches)
-- If none are found, look for Unicode substitute expressions of the correct kind instead.
set containsGarbledBlips to (matchCount > 0)
if (not containsGarbledBlips) then
set aHandyRegex to |⌘|'s class "NSRegularExpression"'s regularExpressionWithPattern:("(\\\\U[[:hex:]]{4})") options:(0) |error|:(missing value)
set regexMatches to aHandyRegex's matchesInString:(theText) options:(0) range:({0, theText's |length|()})
set matchCount to (count regexMatches)
end if
-- If either kind is found, reconstitute the original characters and substitute them for the matched expressions.
if (matchCount > 0) then
set theText to theText's mutableCopy()
repeat with i from (count regexMatches) to 1 by -1 -- Reverse loop because theText's length will change.
-- With each match, get the text matching the first first capture group in the regex.
set thisMatch to item i of regexMatches
set subrange1 to (thisMatch's rangeAtIndex:(1))
set component1 to (theText's substringWithRange:(subrange1))
-- Convert it to data using 7-bit ASCII encoding.
set dataObj to (component1's dataUsingEncoding:(|⌘|'s NSASCIIStringEncoding))
-- Convert it back to a character using "non-lossy ASCII" encoding.
set reconstitutedCharacter to (|⌘|'s class "NSString"'s alloc()'s initWithData:(dataObj) encoding:(|⌘|'s NSNonLossyASCIIStringEncoding))
-- If dealing with misderived expressions, perform a further twiddle.
if (containsGarbledBlips) then
-- Get the text matching the other capture group in the regex.
set subrange2 to (thisMatch's rangeAtIndex:(2))
set component2 to (theText's substringWithRange:(subrange2))
-- Convert that to data using 7-bit ASCII encoding.
set dataObj to (component2's dataUsingEncoding:(|⌘|'s NSASCIIStringEncoding))
-- Convert it back to a character using "non-lossy ASCII" encoding.
set component2 to (|⌘|'s class "NSString"'s alloc()'s initWithData:(dataObj) encoding:(|⌘|'s NSNonLossyASCIIStringEncoding))
-- Convert the first character back to data, now with ISO Latin-1 encoding.
set dataObj to (reconstitutedCharacter's dataUsingEncoding:(|⌘|'s NSISOLatin1StringEncoding))'s mutableCopy()
-- Convert the second character to data too and append it to the data from the first.
tell dataObj to appendData:(component2's dataUsingEncoding:(|⌘|'s NSISOLatin1StringEncoding))
-- Convert the combination back to a single character using UTF-8 encoding.
set reconstitutedCharacter to (|⌘|'s class "NSString"'s alloc()'s initWithData:(dataObj) encoding:(|⌘|'s NSUTF8StringEncoding))
end if
-- Replace the whole of the matched expression in the text with the character derived from it.
tell theText to replaceCharactersInRange:(thisMatch's range()) withString:(reconstitutedCharacter)
end repeat
end if
return theText -- as text
end decodeText
In case there’s anyone still hanging in here, I maintain that making these “corrections” is wrong. If the file says “François”, even if the correct name is “François”, the code should return what the file (and iTunes) says, in this case “François”.
I tend to agree, although maybe it should be that the main code should return what the file says and a “correction” after-process can be bolted on if people like Yvan so wish.
I wrote the correction handlers mainly out of interest and for the challenge. They only handle the situations I currently know about and assume that intended eight-bit-or-more characters aren’t adjacent to each other in the text.
Any ideas on how to stop the script from moving files that have null in any of the below fields. I can get it to prompt but it continues to move the file.
This is the last part I need to work.
#SOME MP3 TAGS ARE NOT PROPERLY FILLED OUT- THIS BELOW PART DOESNT WORK AS SCRIPT PROCEEDS??????. # problem solved below
if (count theGenre) ≤ (count "(null)") and theGenre contains "null" then display dialog "Error: " & theTitle & " has a blank field - Please Fix (no Genre)"
if (count theArtist) ≤ (count "(null)") and theArtist contains "null" then display dialog "Error: " & theTitle & " has a blank field - Please Fix (no Artist)"
if (count theTempo) ≤ (count "(null)") and theTempo contains "null" then display dialog "Error: " & (theFile as text) & " has a blank field - Please Fix (no Tempo)"
if (count theKey) ≤ (count "(null)") and theKey contains "null" then display dialog "Error: " & theTitle & " has a blank field - Please Fix (no Key)"
the above script doesn’t work. I selected the mp3, it only creates the genre and artist folder path but doesn’t move the actual file.
Is there any chance you could modify the below?. So that it doesn’t move the file if the genre,artist,key and tempo are equal to null.
FYI the mp3/aiff I use come from beatport so all the BPM,Key etc are filled out when you buy them. However sometimes I might select a folder that may not contain Beatport mp3s within, hence why I don’t want to move them.
use AppleScript version "2.4" # requires at least Yosemite
use scripting additions
use framework "Foundation"
on listFolder:POSIXPath # handler using ASObjC
set fileManager to current application's NSFileManager's defaultManager()
set aURL to current application's |NSURL|'s fileURLWithPath:POSIXPath
set theOptions to (current application's NSDirectoryEnumerationSkipsPackageDescendants as integer) + (current application's NSDirectoryEnumerationSkipsHiddenFiles as integer)
set theEnumerator to fileManager's enumeratorAtURL:aURL includingPropertiesForKeys:{} options:theOptions errorHandler:(missing value)
set theFiles to theEnumerator's allObjects()
set theFiles to theFiles's filteredArrayUsingPredicate:(current application's NSPredicate's predicateWithFormat:"(lastPathComponent ENDSWITH '.mp3') OR (lastPathComponent ENDSWITH '.aiff')")
return theFiles as list # if we work upon files
--return (theFiles's valueForKey:"path") as list # if we work upon POSIX paths
end listFolder:
-- Creates a new folder. There is no error if the folder already exists, and it will also create intermediate folders if required
on createFolder:POSIXPath
set |⌘| to current application
set theFolderURL to |⌘|'s |NSURL|'s fileURLWithPath:POSIXPath
set theFileManager to |⌘|'s NSFileManager's defaultManager()
set {theResult, theError} to theFileManager's createDirectoryAtURL:theFolderURL withIntermediateDirectories:true attributes:(missing value) |error|:(reference)
if not (theResult as boolean) then error (theError's |localizedDescription|() as text)
end createFolder:
set theFolder to choose folder with prompt "Please select a folder containing MP3/AIFF files" # ADDED
set theFiles to its listFolder:(POSIX path of theFolder) # ADDED
repeat with aFile in theFiles
my treatThisFile(aFile)
end repeat
on treatThisFile(theFile)
set posixFilePath to the quoted form of (POSIX path of theFile)
set genreTag to (do shell script "mdls " & posixFilePath & " -name kMDItemMusicalGenre")
set artistTag to (do shell script "mdls " & posixFilePath & " -name kMDItemAuthors")
set tempoTag to (do shell script "mdls " & posixFilePath & " -name kMDItemTempo")
set keyTag to (do shell script "mdls " & posixFilePath & " -name kMDItemKeySignature")
set titleTag to (do shell script "mdls " & posixFilePath & " -name kMDItemTitle")
set theGenre to text ((offset of "= " in genreTag) + 3) through -2 of genreTag
set theArtist to text ((offset of "= " in artistTag) + 9) through -4 of artistTag
set theTempo to text ((offset of "= " in tempoTag) + 2) through -1 of tempoTag
set theKey to text ((offset of "= " in keyTag) + 3) through -2 of keyTag
set theTitle to text ((offset of "= " in titleTag) + 3) through -2 of titleTag
#SOME MP3 TAGS ARE NOT PROPERLY FILLED OUT- THIS BELOW PART DOESNT WORK AS SCRIPT PROCEEDS??????. # problem solved below
if (count theGenre) ≤ (count "(null)") and theGenre contains "null" then display dialog "Error: " & theTitle & " has a blank field - Please Fix (no Genre)"
if (count theArtist) ≤ (count "(null)") and theArtist contains "null" then display dialog "Error: " & theTitle & " has a blank field - Please Fix (no Artist)"
if (count theTempo) ≤ (count "(null)") and theTempo contains "null" then display dialog "Error: " & (theFile as text) & " has a blank field - Please Fix (no Tempo)"
if (count theKey) ≤ (count "(null)") and theKey contains "null" then display dialog "Error: " & theTitle & " has a blank field - Please Fix (no Key)"
# For some files, theTitle is returned as "null" or "(null)" so it may generate duplicates # Edited
# I choose to use the original name deprieved of the extension
if (count theTitle) ≤ (count "(null)") and theTitle contains "null" then # EDITED
tell application "System Events" # ADDED
set theTitle to text 1 thru -5 of (get name of file (theFile as text))
end tell
end if
set renamedTitle to ("{" & theTempo & "-" & theKey & "} " & theTitle)
set DestFolder to ("/Volumes/Production/test/" & theGenre & "/" & theArtist)
--set DestFolder to ("/Volumes/Macintosh HD/Users/Important/Test/" & theGenre & "/" & theArtist)
my createFolder:DestFolder
set DestFolder to POSIX file DestFolder
set theFile to (theFile as text) as alias # ADDED. Finder refuse to get extension or rename the object returned by the ASObjC handler
tell application "Finder"
set theExtension to name extension of theFile
set name of theFile to renamedTitle & "." & theExtension #AS MAYBE AIFF OR MP3
try
move theFile to DestFolder
on error errMsg
display dialog renamedTitle & errMsg # IF ALREADY EXISTS WILL PROMPT
end try
end tell
end treatThisFile
error "You don't have permission to save the file "Derek Howell" in the folder "Progressive House"." number -2700 from «script» to item
Can you please amend the below script (the first one) to not move null mp3s.
use AppleScript version "2.4" # requires at least Yosemite
use scripting additions
use framework "Foundation"
on listFolder:POSIXPath # handler using ASObjC
set fileManager to current application's NSFileManager's defaultManager()
set aURL to current application's |NSURL|'s fileURLWithPath:POSIXPath
set theOptions to (current application's NSDirectoryEnumerationSkipsPackageDescendants as integer) + (current application's NSDirectoryEnumerationSkipsHiddenFiles as integer)
set theEnumerator to fileManager's enumeratorAtURL:aURL includingPropertiesForKeys:{} options:theOptions errorHandler:(missing value)
set theFiles to theEnumerator's allObjects()
set theFiles to theFiles's filteredArrayUsingPredicate:(current application's NSPredicate's predicateWithFormat:"(lastPathComponent ENDSWITH '.mp3') OR (lastPathComponent ENDSWITH '.aiff')")
return theFiles as list # if we work upon files
--return (theFiles's valueForKey:"path") as list # if we work upon POSIX paths
end listFolder:
-- Creates a new folder. There is no error if the folder already exists, and it will also create intermediate folders if required
on createFolder:POSIXPath
set |⌘| to current application
set theFolderURL to |⌘|'s |NSURL|'s fileURLWithPath:POSIXPath
set theFileManager to |⌘|'s NSFileManager's defaultManager()
set {theResult, theError} to theFileManager's createDirectoryAtURL:theFolderURL withIntermediateDirectories:true attributes:(missing value) |error|:(reference)
if not (theResult as boolean) then error (theError's |localizedDescription|() as text)
end createFolder:
set theFolder to choose folder with prompt "Please select a folder containing MP3/AIFF files" # ADDED
set theFiles to its listFolder:(POSIX path of theFolder) # ADDED
repeat with aFile in theFiles
my treatThisFile(aFile)
end repeat
on treatThisFile(theFile)
set posixFilePath to the quoted form of (POSIX path of theFile)
set genreTag to (do shell script "mdls " & posixFilePath & " -name kMDItemMusicalGenre")
set artistTag to (do shell script "mdls " & posixFilePath & " -name kMDItemAuthors")
set tempoTag to (do shell script "mdls " & posixFilePath & " -name kMDItemTempo")
set keyTag to (do shell script "mdls " & posixFilePath & " -name kMDItemKeySignature")
set titleTag to (do shell script "mdls " & posixFilePath & " -name kMDItemTitle")
set theGenre to text ((offset of "= " in genreTag) + 3) through -2 of genreTag
set theArtist to text ((offset of "= " in artistTag) + 9) through -4 of artistTag
set theTempo to text ((offset of "= " in tempoTag) + 2) through -1 of tempoTag
set theKey to text ((offset of "= " in keyTag) + 3) through -2 of keyTag
set theTitle to text ((offset of "= " in titleTag) + 3) through -2 of titleTag
#SOME MP3 TAGS ARE NOT PROPERLY FILLED OUT- THIS BELOW PART DOESNT WORK AS SCRIPT PROCEEDS??????. # problem solved below
if (count theGenre) ≤ (count "(null)") and theGenre contains "null" then display dialog "Error: " & theTitle & " has a blank field - Please Fix (no Genre)"
if (count theArtist) ≤ (count "(null)") and theArtist contains "null" then display dialog "Error: " & theTitle & " has a blank field - Please Fix (no Artist)"
if (count theTempo) ≤ (count "(null)") and theTempo contains "null" then display dialog "Error: " & (theFile as text) & " has a blank field - Please Fix (no Tempo)"
if (count theKey) ≤ (count "(null)") and theKey contains "null" then display dialog "Error: " & theTitle & " has a blank field - Please Fix (no Key)"
# For some files, theTitle is returned as "null" or "(null)" so it may generate duplicates # Edited
# I choose to use the original name deprieved of the extension
if (count theTitle) ≤ (count "(null)") and theTitle contains "null" then # EDITED
tell application "System Events" # ADDED
set theTitle to text 1 thru -5 of (get name of file (theFile as text))
end tell
end if
set renamedTitle to ("{" & theTempo & "-" & theKey & "} " & theTitle)
set DestFolder to ("/Volumes/Production/test/" & theGenre & "/" & theArtist)
--set DestFolder to ("/Volumes/Macintosh HD/Users/Important/Test/" & theGenre & "/" & theArtist)
my createFolder:DestFolder
set DestFolder to POSIX file DestFolder
set theFile to (theFile as text) as alias # ADDED. Finder refuse to get extension or rename the object returned by the ASObjC handler
tell application "Finder"
set theExtension to name extension of theFile
set name of theFile to renamedTitle & "." & theExtension #AS MAYBE AIFF OR MP3
try
move theFile to DestFolder
on error errMsg
display dialog renamedTitle & errMsg # IF ALREADY EXISTS WILL PROMPT
end try
end tell
end treatThisFile