I think this job is really better done with curl, as you don’t have to take any delays or such into account, as you have when UI Scripting Safari. (There are many examples of curl-usage to be found here.
Should you wish to proceed with Safari, you should look into some scripts that waits for pageload, there are several examples around here, so you can be sure that your script doesn’t commence, with the UI scripting before Safari gets a chance to react sanely. I believe that to be the culprit, since the generated file isn’t where it should be when your script tries to rename it.
Once set up properly, curl will get the data for you in one go, reliably, every time.
Well, I am not sure if you have to click the button, when you get the page via curl. And did you see the -u option, for entering the username and password?
You have also the verbose mode, for making curl really talkative, so you can figure out what is going on, while you talk to your device by it.
You should also search for curl here, and see how people use it, and have used it, for logging onto stuff, and attaining information.
About the buttons. I think, that if you are lucky, then the field of that page, will get an event that the data is submitted, without you having to click that button, effectively bypassing it. But I may very well be wrong in that. I wouldn’t give up however, before I was sure that the data was entered into the correct fields.
What you should try, is to have a debugger/inspector open in Safari, or whatever browser, and see if you can see the transaction, so that you can hopefully see the post/get event that happens when you submit the data from the form, for that is what you should use curl for, to send over, simulating the filling out of the form.
I did not see your post till just now, sometimes this forum does not send me a mail.
Have just implemented the other suggestions (the clean-up) and testing those. Next i do yours. Do not want to introduce to many new things, so I can see what works or not. Will report if it solved the problem.
Cleaning up the script by using the different solutions above did not work. Worked fine in the script editor, but using it via cron as a application created the same problem as before.
I figured out the curl suggestion, see below. I am now testing it (in cron, as it works fine as a application) and will report back.
do shell script "curl http://192.168.1.190/data_tmp/gespr_dat.csv.gzl -s -o /Users/HDname/Desktop/gespr_dat.csv.gz"
delay 2
-- rename file
tell application "Finder"
set the name of file "gespr_dat.csv.gz" to (("week ") & (do shell script "date +%U") & (".gz"))
end tell
I recommend to put the shell script before the Finder tell block and check for the existence of the file
set weekName to "week " & (do shell script "date +%U" & ".gz")
tell application "Finder"
if exists file "gespr_dat.csv.gz" then
set the name of file "gespr_dat.csv.gz" to weekName
else
log "file 'gespr_dat.csv.gz' does not exist"
end if
end tell
Stefan, I am still fighting with this. I realise that if the file does not exist, the script will try to execute the rest (there is a whole block behind this that will send the file per email, trash it etc.). How do I stop this if there is no file in the first place?
Insert it as a replacement for your previous finder statement that attempted to rename the file. And, I think you should specify the folder where your file should exist, as the working directory of your applet might vary. (I am not sure about this, but a full file reference is always a good practice, when you know where it is to be created.
set weekName to "week " & (do shell script "date +%U" & ".gz")
local probe
try
tell application "Finder" to set probe to file "gespr_dat.csv.gz" as alias
on error
log "full hfs path to gespr_dat.csv.gz didn't exist!"
delay 0.5
repeat
try
tell application "Finder"
set probe to file "gespr_dat.csv.gz" as alias
set the name of file "gespr_dat.csv.gz" to weekName
end tell
exit repeat
on error
delay 0.5
end try
end repeat
end try
If the file is on desktop, then there is no need to specify the folder in a Finder tell block,
because the “root” folder of the Finder is the desktop folder of the current user.
The command exists might be better than forcing errors and the Finder is not needed for the alias coercion.
System Events is also able to perform file system operations so the Finder doesn’t get blocked
set time_out to 10
tell application "System Events"
repeat until (exists file "gespr_dat.csv.gz" of desktop folder) or (time_out is 0)
delay 1.0
set time_out to time_out - 1
end repeat
if time_out = 0 then
log "operation timed out"
else
set name of file "gespr_dat.csv.gz" of desktop folder to weekName
end if
end tell
Nope, that is a Posix path you should use a Hfs path the ones you see in the log with colons inside it.
But you should really read StefanK’s post, if your file is created on Desktop, and not in the downloads folder, then you are fine with specifying just the file.
Nice timeout operation!! I was not sure if you can rename a file when it is busy or not. My approach also covered that possibility, when I wrote my solution, (which would have lead to even more code if I was to consider that together with exists.
But since StefanK’s code, doesn’t have a clause for that, I trust it to not be the case, that there is any problems in renaming a “busy file”
You should really go for his approach, as he has implemented a time-out which I errantly has not.
System events is always a better choice than finder, as Finder are more likely to be bogged down with something.
